Support Ruby 2.4 #34
Closed
Support Ruby 2.4 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanaka51
force-pushed
the
support-ruby-2-4
branch
2 times, most recently
from
873c876 to
bb2111c
Compare
tanaka51
force-pushed
the
support-ruby-2-4
branch
from
bb2111c to
5d603ef
Compare
|
@tanaka51 - Does it work with preview2? |
tanaka51
force-pushed
the
support-ruby-2-4
branch
from
2c1ede5 to
5d603ef
Compare
|
@jasnow Yes, it works on my end. (Travis CI does not support preview2 yet... |
Closed
|
@beauby Sorry for late response. I totally agree with your opinion. Thank you for reviewing my PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I can't install this gem, jsonapi, on Ruby 2.4(preview1 and preview2) because Ruby 2.4 unifies Bignum and Fixnum to Integer and the json gem version 1.8 that this gem dependents on uses both classes. Now, supported version is released as 2.0.
To resolve this issue, I simply removed the json gem dependency.
Thanks.