Skip to content

Conversation

mrkn
Copy link

@mrkn mrkn commented Jul 25, 2016

In this PR, I want to update the minimum version of json.gem to support ruby-head.

In addition, I removed needless Gemfile.lock because it is gem library.

@md5
Copy link

md5 commented Aug 12, 2016

It seems like it would be better to use something like this:

spec.add_dependency 'json', '>= 1.8, < 3'

That way it will not force projects that are still using json 1.8.x to upgrade for no reason.

@mrkn
Copy link
Author

mrkn commented Aug 13, 2016

@md5 That's right. I've updated the commit.

@beauby beauby mentioned this pull request Sep 18, 2016
@beauby
Copy link
Owner

beauby commented Sep 18, 2016

Thanks for the PR @mrkn – I believe the best way around those issues is actually to remove the dependency on json altogether. Let's take care of this in #33, and close this PR.

@beauby beauby closed this Sep 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants