Skip to content

[Feat] Memoize getDefinition parser function #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2021
Merged

[Feat] Memoize getDefinition parser function #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {JSONSchema4Type, JSONSchema4TypeName} from 'json-schema'
import {findKey, includes, isPlainObject, map, omit} from 'lodash'
import {findKey, includes, isPlainObject, map, memoize, omit} from 'lodash'
import {format} from 'util'
import {Options} from './'
import {typesOfSchema} from './typesOfSchema'
Expand Down Expand Up @@ -119,7 +119,7 @@ function parseNonLiteral(
processed: Processed,
usedNames: UsedNames
): AST {
const definitions = getDefinitions(getRootSchema(schema as any)) // TODO
const definitions = getDefinitionsMemoized(getRootSchema(schema as any)) // TODO
const keyNameFromDefinition = findKey(definitions, _ => _ === schema)

switch (type) {
Expand Down Expand Up @@ -433,9 +433,6 @@ via the \`definition\` "${key}".`

type Definitions = {[k: string]: LinkedJSONSchema}

/**
* TODO: Memoize
*/
function getDefinitions(
schema: LinkedJSONSchema,
isSchema = true,
Expand Down Expand Up @@ -469,6 +466,8 @@ function getDefinitions(
return {}
}

const getDefinitionsMemoized = memoize(getDefinitions)

/**
* TODO: Reduce rate of false positives
*/
Expand Down