Initial ACDD Tests #65
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An initial set of ACDD tests. Adapted from ioos/compliance_checker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to share an early draft PR before implementing too many rules to make sure I'm on the right track.
The IOOS compliance checker has implemented their own tests for ACDD, CF, IOOS, and others, but have ended up with a much more complex and hard to adapt library in the process. There is interest in using XRLint to help simplify things, and make it easier to share work across the ecosystem. Along those lines an idea is to move tests/rules upstream if there is interest rather than keeping their own implementation.
I've converted many of the more general ACDD global attribute tests over here.