Added the XKCD antigravity comic in ASCII form (2) #181
Conversation
|
@JoeGlancy really great! Just a few code style issues to fix up, if you don't mind: 4 spaces for tab, curly brackets on the line with the statement, and curly brackets even for 1-liner. Also please squash all commits for the final merge (and rebase against master: git rebase -i master). |
source/microbit/modantigravity.cpp
Outdated
There was a problem hiding this comment.
Please put different names on different lines, ie add the following for you:
Copyright (c) 2016 Joe Glancy
|
I think that's all. |
|
@JoeGlancy you need to add yourself to the AUTHORS file. ;-) |
|
Yes, looks good, but please combine commits into one. |
|
@JoeGlancy |
|
I was sure I already did. I'll do both tonight when I find time. |
|
Great stuff and thanks! Looks like this'll make it into the imminent 1.0 release. 😄 |
|
Sweet! I look forward to it :) |
|
Also, make sure you add yourself to the AUTHORS file before you roll up all the commits..! |
|
Will do! |
|
Done? |
…) version and the full version (also updated AUTHORS file).
|
Ok, great, it's now 256 bytes (the small version of the comic with 1 pane). There are still 6 commits that need squashing, but I can do this with a rebase myself, unless there are objections? |
|
Finally, all into one commit! |
|
Great work, thanks for your contribution! And hopefully you learned a bit more about using git :) |
|
Yup 👍 :) |
3 participants
I re-created the XKCD antigravity comic (http://xkcd.com/353/) in ASCII form, and added it to the antigravity module to simulate the classic Python antigravity. There's two versions, the micro one (default), and the full one (optionally swappable for the micro one at build time). It uses the RLE as suggested by @whaleygeek and @dpgeorge to encode the strings. The micro comic, both text and RLE printing code, is 288 bytes. The larger comic, both text and RLE code, is just over 1KB (1053 bytes).