-
Notifications
You must be signed in to change notification settings - Fork 91
Add karma_web_test and karma_web_test_suite #363
Add karma_web_test and karma_web_test_suite #363
Conversation
alexeagle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we have the user supply a karma plugin rather than a karma conf? Then we don't have the problem that they provide karma settings that conflict with ours under bazel, requiring warnings like we do for tsconfig overrides or similar
rollup_bundle already allows plugins
|
Added
karma-js.conf.js: Test target of SauceLabs, BrowserStack or local chrome controlled by |
|
That's a good question. The plugin would have to be able to be able to override configuration values such as |
alexeagle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you already tried to reduce the duplication?
The approach looks good to me, I'll let @kyliau review the karma-specific bits
| _ts_web_test_suite = "ts_web_test_suite", | ||
| ) | ||
| load( | ||
| "//internal/karma:karma_web_test.bzl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure we should put this in the public API yet.
I think generally we should have some process for maturing new rules before they go in the public API
kyliau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Switches all `ts_web_test_suite` targets to the new `karma_web_test_suite` rule. `ts_web_test_suite` is based on the `karma_web_test_suite` rule but does not allow developers to have a custom karma configuration. In order to be able to provide a custom karma configuration for setting up Saucelabs and Browserstack, we switch all targets over to the `karma_web_test_suite` rule. See: bazelbuild/rules_typescript#363.
Switches all `ts_web_test_suite` targets to the new `karma_web_test_suite` rule. `ts_web_test_suite` is based on the `karma_web_test_suite` rule but does not allow developers to have a custom karma configuration. In order to be able to provide a custom karma configuration for setting up Saucelabs and Browserstack, we switch all targets over to the `karma_web_test_suite` rule. See: bazelbuild/rules_typescript#363.
Switches all `ts_web_test_suite` targets to the new `karma_web_test_suite` rule. `ts_web_test_suite` is based on the `karma_web_test_suite` rule but does not allow developers to have a custom karma configuration. In order to be able to provide a custom karma configuration for setting up Saucelabs and Browserstack, we switch all targets over to the `karma_web_test_suite` rule. See: bazelbuild/rules_typescript#363.
Switches all `ts_web_test_suite` targets to the new `karma_web_test_suite` rule. `ts_web_test_suite` is based on the `karma_web_test_suite` rule but does not allow developers to have a custom karma configuration. In order to be able to provide a custom karma configuration for setting up Saucelabs and Browserstack, we switch all targets over to the `karma_web_test_suite` rule. See: bazelbuild/rules_typescript#363.
Switches all `ts_web_test_suite` targets to the new `karma_web_test_suite` rule. `ts_web_test_suite` is based on the `karma_web_test_suite` rule but does not allow developers to have a custom karma configuration. In order to be able to provide a custom karma configuration for setting up Saucelabs and Browserstack, we switch all targets over to the `karma_web_test_suite` rule. See: bazelbuild/rules_typescript#363.
Switches all `ts_web_test_suite` targets to the new `karma_web_test_suite` rule. `ts_web_test_suite` is based on the `karma_web_test_suite` rule but does not allow developers to have a custom karma configuration. In order to be able to provide a custom karma configuration for setting up Saucelabs and Browserstack, we switch all targets over to the `karma_web_test_suite` rule. See: bazelbuild/rules_typescript#363. (cherry picked from commit c791926)
Adds karma_web_test and karma_web_test_suite which accepts a user base karma configuration in
config_fileattribute. ts_web_test (a generic web_test rule) uses karma_web_test code under the hood but does not accept a karma configuration. Updatedexamples/testing:testingto also show karm_web_test usage.Also some general cleanup in the karma rule.
Prerequisite for angular/angular#27721.