Skip to content

Output command lines of failed action command line tests #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Output command lines of failed action command line tests #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/rules/action_command_line_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,20 @@ def _action_command_line_test_impl(ctx):
if expected + " " not in concatenated_args:
unittest.fail(
env,
"{}expected argv to contain '{}', but it did not".format(
"{}expected argv to contain '{}', but it did not: {}".format(
message_prefix,
expected,
concatenated_args,
),
)
for not_expected in ctx.attr.not_expected_argv:
if not_expected + " " in concatenated_args:
unittest.fail(
env,
"{}expected argv to not contain '{}', but it did".format(
"{}expected argv to not contain '{}', but it did: {}".format(
message_prefix,
not_expected,
concatenated_args,
),
)

Expand Down