Skip to content

fail(...) if both crate and crate_root attrs are specified on rust_test #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fail(...) if both crate and crate_root attrs are specified on rust_test #3622

wants to merge 3 commits into from

Conversation

bmoxb
Copy link
Contributor

@bmoxb bmoxb commented Sep 17, 2025 •
edited
Loading

Conceptually, it doesn't really make sense for a rust_test to have both a crate and crate_root specified, plus for compilation purposes the crate root of the library target specified by crate is inherited anyway.

@bmoxb bmoxb mentioned this pull request Sep 17, 2025
Merged
krasimirgg
krasimirgg reviewed Sep 17, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasimirgg krasimirgg krasimirgg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmoxb @krasimirgg