fix(gazelle): handle purelib and platlib packages that don't set 'Root-Is-Purelib: true' #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-Is-Purelib: true'
mattem
force-pushed
the
fix/what-s-the-deal-with-purelib-vs-platlib
branch
from
33a136f to
b164771
Compare
alexeagle
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wheels can contain their package within the
.datadirectory, inside thepureliborplatlibdirectories, which is then unpacked into the correctsite-packagesfolder.Previously these directories were ignored, but this causes issues with packages such as
semgrepthat don't setRoot-Is-Purelib: trueand instead have thepurelibdirectory under the.datapackage.This is the same as setting
Root-Is-Purelib: trueand having all the files at the root, so I'm unsure of the reasons to do it this way 🤷This results in the package being missing from the gazelle_python manifest files, and therefore causing issues with resolving dependencies.