feat(pypi): support aarch64 windows on pipstar #3226
Conversation
This adds the necessary bits for Windows ARM64 support when evaluating env markers in requirements files and selecting the right wheels in `experimental_index_url`. Related bazel-contrib#2276
aignas
force-pushed
the
feat/add-defaults-for-pypi-support-for-windows-arm64
branch
from
82c42d3 to
c4c9668
Compare
|
We cannot do this because we have tests using the TBH, maybe we should treat this as a bug and fix it. |
|
Yeah, it's something we should fix. It should be OK for a requirements file to not support the full set of platforms the entire build does. I can see that situation happening in a larger repo. |
|
Another thought: does this mean if we add a new platform to rules_python's default, downstream user requirements could break? Eek. |
|
I think the best way would be to hardcode windows to only mean windows intel, then for linux and osx, do similar things. The users should really be specifying things explicitly... Otherwise us adding platforms may break bazel quely. |
This adds the necessary bits for Windows ARM64 support when evaluating
env markers in requirements files and selecting the right wheels in
experimental_index_url.Related #2276