fix(gazelle): Do not build proto targets with default Gazelle #3216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougthor42
changed the title
aignas
approved these changes
Aug 27, 2025
|
@rickeylev or @aignas: Do I need to merge this PR into the 1.6rc0 branch? ie: what's the release process for fixes after a RC branch has been made? |
aignas
pushed a commit
that referenced
this pull request
Sep 8, 2025
Fixes #3209. Revert the change to `//:gazelle_binary` so that it once again only generates python code. We then create a new, private target `//:_gazelle_binary_with_proto` that gets used by tests. Update docs accordingly. Longer term, I'd like to adjust the `test.yaml` file to include a section: ```yaml config: gazelle_binary: _gazelle_binary_with_proto ``` So that test cases that need to generate `(py_)proto_library` targets can use the multi-lang Gazelle binary and that tests that do _not_ need to generate proto targets can use the single-lang Gazelle binary. However, there were some minor roadblocks in doing so and thus I'm doing this quick-to-implement method instead. (cherry picked from commit 2ed714f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3209.
Revert the change to
//:gazelle_binaryso that it once again only generates python code. We then create a new, private target//:_gazelle_binary_with_protothat gets used by tests.Update docs accordingly.
Longer term, I'd like to adjust the
test.yamlfile to include a section:So that test cases that need to generate
(py_)proto_librarytargets can use the multi-lang Gazelle binary and that tests that do not need to generate proto targets can use the single-lang Gazelle binary.However, there were some minor roadblocks in doing so and thus I'm doing this quick-to-implement method instead.