Skip to content

Loosen dash in proto path name check #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Loosen dash in proto path name check #1925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/private/proto/py_proto_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def _py_proto_aspect_impl(target, ctx):

# Check Proto file names
for proto in target[ProtoInfo].direct_sources:
if proto.is_source and "-" in proto.dirname:
if proto.is_source and "-" in proto.owner.package:
Copy link
Collaborator

@aignas aignas May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test to ensure that this actually works? Having the examples/bzlmod/proto be expanded would be great.

Whilst at it a note in CHANGELOG.md would be also great.

I think the reasoning in #1924 makes sense, so +1 for making the change.

fail("Cannot generate Python code for a .proto whose path contains '-' ({}).".format(
proto.path,
))
Expand Down