Skip to content

11.x dto refactoring #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2024
Merged

11.x dto refactoring #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48f82c9
add gmp-ext
rez1dent3 Jan 5, 2024
5f31479
Revert "add gmp-ext"
rez1dent3 Jan 5, 2024
9579ffd
dto fix
rez1dent3 Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Internal/Assembler/TransactionDtoAssembler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@

use Bavix\Wallet\Internal\Dto\TransactionDto;
use Bavix\Wallet\Internal\Dto\TransactionDtoInterface;
use Bavix\Wallet\Internal\Service\ClockServiceInterface;
use Bavix\Wallet\Internal\Service\UuidFactoryServiceInterface;
use Illuminate\Database\Eloquent\Model;

final readonly class TransactionDtoAssembler implements TransactionDtoAssemblerInterface
{
public function __construct(
private UuidFactoryServiceInterface $uuidService
private UuidFactoryServiceInterface $uuidService,
private ClockServiceInterface $clockService,
) {
}

Expand All @@ -33,7 +35,9 @@ public function create(
$type,
$amount,
$confirmed,
$meta
$meta,
$this->clockService->now(),
$this->clockService->now(),
);
}
}
8 changes: 6 additions & 2 deletions src/Internal/Assembler/TransferDtoAssembler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@

use Bavix\Wallet\Internal\Dto\TransferDto;
use Bavix\Wallet\Internal\Dto\TransferDtoInterface;
use Bavix\Wallet\Internal\Service\ClockServiceInterface;
use Bavix\Wallet\Internal\Service\UuidFactoryServiceInterface;
use Illuminate\Database\Eloquent\Model;

final readonly class TransferDtoAssembler implements TransferDtoAssemblerInterface
{
public function __construct(
private UuidFactoryServiceInterface $uuidService
private UuidFactoryServiceInterface $uuidService,
private ClockServiceInterface $clockService,
) {
}

Expand All @@ -34,7 +36,9 @@ public function create(
$fromModel->getKey(),
$toModel->getKey(),
$discount,
$fee
$fee,
$this->clockService->now(),
$this->clockService->now(),
);
}
}
10 changes: 3 additions & 7 deletions src/Internal/Dto/TransactionDto.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@
/** @immutable */
final readonly class TransactionDto implements TransactionDtoInterface
{
private DateTimeImmutable $createdAt;

private DateTimeImmutable $updatedAt;

/**
* @param array<mixed>|null $meta
*/
Expand All @@ -24,10 +20,10 @@ public function __construct(
private string $type,
private float|int|string $amount,
private bool $confirmed,
private ?array $meta
private ?array $meta,
private DateTimeImmutable $createdAt,
private DateTimeImmutable $updatedAt,
) {
$this->createdAt = new DateTimeImmutable();
$this->updatedAt = new DateTimeImmutable();
}

public function getUuid(): string
Expand Down
10 changes: 3 additions & 7 deletions src/Internal/Dto/TransferDto.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@
/** @immutable */
final readonly class TransferDto implements TransferDtoInterface
{
private DateTimeImmutable $createdAt;

private DateTimeImmutable $updatedAt;

public function __construct(
private string $uuid,
private int $depositId,
Expand All @@ -21,10 +17,10 @@ public function __construct(
private int $fromId,
private int $toId,
private int $discount,
private string $fee
private string $fee,
private DateTimeImmutable $createdAt,
private DateTimeImmutable $updatedAt,
) {
$this->createdAt = new DateTimeImmutable();
$this->updatedAt = new DateTimeImmutable();
}

public function getUuid(): string
Expand Down