Skip to content

Conversation

@rez1dent3
Copy link
Member

@rez1dent3 rez1dent3 commented Sep 23, 2022

WARNING: Never use package services in a constructor!!!

#570

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 25, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d27ce62
Status: ✅  Deploy successful!
Preview URL: https://c69c7b4c.laravel-wallet.pages.dev
Branch Preview URL: https://570-octane.laravel-wallet.pages.dev

View logs

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #573 (d27ce62) into master (289519f) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #573   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       453       455    +2     
===========================================
  Files             72        72           
  Lines           1378      1391   +13     
===========================================
+ Hits            1378      1391   +13     
Impacted Files Coverage Δ
src/Internal/Service/DatabaseService.php 100.00% <100.00%> (ø)
src/Internal/Service/LockService.php 100.00% <100.00%> (ø)
src/Internal/Service/StateService.php 100.00% <100.00%> (ø)
src/Internal/Service/StorageService.php 100.00% <100.00%> (ø)
src/Services/RegulatorService.php 100.00% <100.00%> (ø)
src/WalletServiceProvider.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rez1dent3 rez1dent3 marked this pull request as ready for review September 28, 2022 17:13
@rez1dent3 rez1dent3 changed the title partial octane support [9.4] partial octane support Sep 28, 2022
@rez1dent3 rez1dent3 added enhancement New feature or request 9.x-dev labels Sep 28, 2022
@rez1dent3 rez1dent3 merged commit 2b9a218 into master Sep 29, 2022
@rez1dent3 rez1dent3 deleted the 570-octane branch September 29, 2022 15:42
@rez1dent3 rez1dent3 self-assigned this Sep 29, 2022
@rez1dent3 rez1dent3 linked an issue Oct 19, 2022 that may be closed by this pull request
@rez1dent3 rez1dent3 removed a link to an issue Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.x-dev enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Almost always getting LockTimeoutException upgrading from transaction to atomic service

2 participants