How can new columns be added in transactions in version 10.x?

[hamedkhorasani]

Hello @rez1dent3
I appreciate your help in creating this package.
I need a new field named 'transaction_name' for grouping deposits and withdrawals, along with a 'parent' field. In version 10.x, I was unable to add two new fields to the transaction.
If possible, could you explain this with an example?

[rez1dent3]

Hello, @hamedkhorasani.

I would not recommend adding new fields, because... There is a meta field of the json type that covers most cases. BUT there is a need, then you need to do this:

1. Override TransactionDtoTransformerInterface interface:

laravel-wallet/tests/Infra/Transform/TransactionDtoTransformerCustom.php

Lines 18 to 28 in ae394c5

	public function extract(TransactionDtoInterface $dto): array
	{
	$bankMethod = null;
	if ($dto->getMeta() !== null) {
	$bankMethod = $dto->getMeta()['bank_method'] ?? null;
	}
	return array_merge($this->transactionDtoTransformer->extract($dto), [
	'bank_method' => $bankMethod,
	]);
	}

2. Override Transaction model:

laravel-wallet/tests/Infra/PackageModels/Transaction.php

Lines 14 to 17 in ae394c5

	public function getFillable(): array
	{
	return array_merge($this->fillable, ['bank_method']);
	}

3. Replace the objects in the wallet.php file.

laravel-wallet/config/config.php

Line 134 in ae394c5

'transaction' => TransactionDtoTransformer::class,

laravel-wallet/config/config.php

Line 168 in ae394c5

'model' => Transaction::class,

4. Migration:

laravel-wallet/tests/migrations/2019_09_19_191432_alter_column_transaction_table.php

Lines 13 to 17 in a9c30b7

	Schema::table((new Transaction())->getTable(), static function (Blueprint $table) {
	$table->string('bank_method')
	->nullable()
	;
	});

---

In the example, the bank_method field is added, and you will need to register your fields.

Work with fields via meta, so as not to redefine all package interfaces.

laravel-wallet/tests/Units/Domain/WalletExtensionTest.php

Lines 31 to 38 in a9c30b7

	$transaction = $buyer->deposit(1000, [
	'bank_method' => 'VietComBank',
	]);
	self::assertTrue($transaction->getKey() > 0);
	self::assertSame($transaction->amountInt, $buyer->balanceInt);
	self::assertInstanceOf(Transaction::class, $transaction);
	self::assertSame('VietComBank', $transaction->bank_method);

[hamedkhorasani]

@rez1dent3 Thank you for your response.
Does adding a key in the meta field to establish a relationship in the database reduce performance?

[rez1dent3]

Does adding a key in the meta field to establish a relationship in the database reduce performance?

The answer to the question depends heavily on the database.

Adding columns has an effect, but the meta field already exists and is filled in. It all depends on the volume and database.

[rez1dent3]

Since there are no more questions, I will close the issue.
There will be additional questions - it is better to create a new issue.