Extending transaction model

[smtlab]

Hey @rez1dent3

Can you suggest to me how should I go about the below use case?

I am working on the logistics app, where I have shipments from multiple customers.

Every customer has cod-wallet
I have to deposit Cash on delivery amount from shipments to cod-wallet.

The problem here is there is a background service which picks up unpaid shipments from DB and processes deposit, also I cannot maintain any flag in shipment model for paid status as it would not be reliable, I directly want to join with transactions table and check if the entry exists with type deposit for a shipment.

Unfortunately, the transaction only takes metadata from the user side, using the JSON column I cannot take advantage of joins.

My thoughts on giving developers the flexibility to customize model

• We can have a morphTo relation in the transaction model for developers to extend according to their requirements and allow developers to pass transaction class while doing transactions.
• We can make use of virtual columns reference: https://mysqlserverteam.com/indexing-json-documents-via-virtual-columns/#:~:text=As%20the%20MySQL%20manual%20notes,value%20from%20the%20JSON%20column.
• add an external_ref_id column to transaction table

Any suggestions would really help.

Thanks in advance

[rez1dent3]

Hello @smtlab.

You can add the required columns to the database yourself. Someone asked me already like this..
Here's an example.

Migrating a table:

laravel-wallet/tests/migrations/2019_09_19_191432_alter_column_transaction_table.php

Lines 17 to 19 in 1c26faf

	Schema::table((new Transaction())->getTable(), function (Blueprint $table) {
	$table->string('bank_method')->nullable();
	});

Adding data on insertion:

laravel-wallet/tests/Objects/Operation.php

Lines 3 to 18 in 1c26faf

	namespace Bavix\Wallet\Test\Objects;
	class Operation extends \Bavix\Wallet\Objects\Operation
	{
	/**
	* @return array
	*/
	public function toArray(): array
	{
	return \array_merge(parent::toArray(), [
	'bank_method' => $this->meta['bank_method'] ?? null,
	]);
	}
	}

Overriding the transaction record object:

laravel-wallet/tests/WalletExtensionTest.php

Line 19 in 1c26faf

$this->app->bind(Operation::class, Objects\Operation::class);

And now we write data to the database:

laravel-wallet/tests/WalletExtensionTest.php

Lines 31 to 36 in 1c26faf

	self::assertFalse($buyer->relationLoaded('wallet'));
	$transaction = $buyer->deposit(1000, ['bank_method' => 'VietComBank']);
	self::assertEquals($transaction->amount, $buyer->balance);
	self::assertInstanceOf(Transaction::class, $transaction);
	self::assertEquals('VietComBank', $transaction->bank_method);

For convenience, you can override the Transaction model:

laravel-wallet/tests/TestCase.php

Line 68 in 1c26faf

$app['config']->set('wallet.transaction.model', Transaction::class);

Nothing else is needed. The complete code is available here, here and here)))

[smtlab]

@rez1dent3 Thanks for giving a detailed explanation, really appreciate your time :)

I completely missed the config file, I see I can override all services and models.

[atapatel]

@smtlab can you please share your logic for expiry logic here?

[nagsamayam]

Hi @rez1dent3

Thank you soo much for providing such a great package.
In the above comment you have suggested use Bavix\Wallet\Objects\Operation class to store additional 'trasactions' table columns data. But I didn't see the Bavix\Wallet\Objects\Operation class in the codebase. Can you please suggest how to add additional columns for 'transactions' table?

[rez1dent3]

@nagsamayam Hello. I don't check old issue, I found your question by accident. If you want to discuss in more detail, then create a new issue.

Yes, Operation no longer exists, but it is still possible to implement this functionality. An example is in unit tests:

laravel-wallet/tests/Infra/Transform/TransactionDtoTransformerCustom.php

Lines 18 to 28 in 88913b5

	public function extract(TransactionDtoInterface $dto): array
	{
	$bankMethod = null;
	if ($dto->getMeta() !== null) {
	$bankMethod = $dto->getMeta()['bank_method'] ?? null;
	}
	return array_merge($this->transactionDtoTransformer->extract($dto), [
	'bank_method' => $bankMethod,
	]);
	}

[nagsamayam]

@nagsamayam Hello. I don't check old issue, I found your question by accident. If you want to discuss in more detail, then create a new issue.

Yes, Operation no longer exists, but it is still possible to implement this functionality. An example is in unit tests:

laravel-wallet/tests/Infra/Transform/TransactionDtoTransformerCustom.php

Lines 18 to 28 in 88913b5

	public function extract(TransactionDtoInterface $dto): array
	{
	$bankMethod = null;
	if ($dto->getMeta() !== null) {
	$bankMethod = $dto->getMeta()['bank_method'] ?? null;
	}
	return array_merge($this->transactionDtoTransformer->extract($dto), [
	'bank_method' => $bankMethod,
	]);
	}

Hi @rez1dent3
Thank you soo much for the solution provided and also noted your suggestion to create new issue. Once again thank you so much for providing package.