Support multi-arity methods with definterface
#551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multi-arity methods to
definterface.Removes multi-arity support for class and static methods of
deftypes, because they don't really make sense. Class and static methods are Python interop features, rather than Basilisp language features and Python does not support multi-arity methods, so there's little point in supporting multi-arity variants of these method types.definterfacewill not support class or static methods at all, since this is a feature intended only for Python interop.Fix a bug where function (and method) arities with the same fixed arity as a variadic arity were allowed when they appear after the variadic arity in the definition, but not allowed if they appeared before.
Fixes #538