Add JSON encoder and decoder #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrink10
commented
Jun 1, 2020
| (->> (group-by first methods) | ||
| (reduce (fn [m [method-name arities]] | ||
| (->> (map rest arities) | ||
| (apply list `fn method-name) |
Member
Author
There was a problem hiding this comment.
If the extended method function uses the dispatch method name, then the compiler will add the local function name to the symbol table for that name and users will be unable to call the generic Protocol dispatch method.
chrisrink10
commented
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a JSON encoder and decoder based on Python's
jsonmodule.This is obviously not going to be the fastest encoder or decoder in the planet, but it will be builtin so folks don't have to fetch another library to do the job. It's made worse by the fact that Python's builtin decoder does not include an
array_hookoption. We could probably make a fairly efficient decoder with that and the existingobject_hook, but since we have the completely decode the entire object to Python objects and then convert, it's probably pretty slow.Fixes #484, #554