add: cifplayer as iframe #148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blokhin Please kindly check it. |
…omponent name as `CIFPlayer`
blokhin
reviewed
Sep 18, 2025
|
|
||
| --- | ||
|
|
||
| **Note:** The viewer is loaded from an external website. Ensure your users have internet access to use this feature. |
There was a problem hiding this comment.
@luckylionheart seems to be a useful comment, pity to delete it
blokhin
requested changes
Sep 23, 2025
There was a problem hiding this comment.
@luckylionheart this is a component, not a layout.
| @@ -1,4 +1,5 @@ | |||
| export * from './Card/'; | |||
| export * from './Cifplayer/'; | |||
There was a problem hiding this comment.
@luckylionheart please, use the name CIFPlayer everywhere consistently, otherwise it is not clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.