Make service provider deferrable to allow for custom (filesystem) service provider #1252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described on a similar PR in the ide-helper, when a serviceprovider is not deferrable, the service provider of a package is registered before any custom service providers in a project are registered.
I am currently working on a project with a custom FileSystemServiceProvider, where requiring the debugbar causes an error in Container.php on line 879
Target class [files] does not existand Container.php on line 877Class "files" does not exist. This issue was also mentioned in #1112.Simplest bug reproduction in code
./app/Providers/CustomFileSystemProvider.php
./config/app.php
This PR adds the DeferrableProvider interface to the package's service provider, and adds the provided services to a
providesmethod so these services can be registered when needed.