Convert from int32 for large integer literals in bitv.ml #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the ocaml compiler emits bytecode for 32-bit architectures, large interger literals will cause it to fail. 32-bit marshalling is most commonly used when compiling with the Js_of_ocaml backend. This error message is what you'd see when attempting to use ocamlgraph in a JSOO project: ``` ----line 1 of _none_ col 1 File "_none_", line 1: Error: Generated bytecode library "graph.cma" cannot be used on a 32-bit platform ``` By using 32-bit integer literals[1], we avoid the issue by eschewing platform-native integers. [1] https://v2.ocaml.org/api/Int32.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ocaml compiler emits bytecode for 32-bit architectures, large interger literals will cause it to fail. 32-bit marshalling is most commonly used when compiling with the Js_of_ocaml backend.
This error message is what you'd see when attempting to use ocamlgraph in a JSOO project:
By using 32-bit integer literals, we avoid the issue by eschewing platform-native integers.