Skip to content

[Snyk] Security upgrade puma from 3.7.0 to 5.6.9 #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade puma from 3.7.0 to 5.6.9 #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion play-with-docker/Portus/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def packaging?
end

# If the deployment is done through Puma, include it in the bundle.
gem "puma", "~> 3.7.0" if ENV["PORTUS_PUMA_DEPLOYMENT"] == "yes" || !packaging?
gem "puma", "~> 5.6.9"
Copy link

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional logic if ENV["PORTUS_PUMA_DEPLOYMENT"] == "yes" || !packaging? was removed, which means Puma will now always be included in the bundle regardless of deployment method or packaging status. This could be a breaking change that affects how the application is deployed in different environments.

Suggested change
gem "puma", "~> 5.6.9"
if ENV["PORTUS_PUMA_DEPLOYMENT"] == "yes" || !packaging?
gem "puma", "~> 5.6.9"
end

Copilot uses AI. Check for mistakes.

# In order to create the Gemfile.lock required for packaging
# meaning that it should contain only the production packages
Expand Down
Loading