Skip to content

Conversation

amirroox
Copy link
Contributor

@amirroox amirroox commented May 27, 2024

Problem

toggle progress is not displayed well in RTL.
It opens, but does not close.
It also doesn't look good.

Change

Fixing "Toggle Progress" For RTL Support

File Edit

  • src/components/LearnProgress.tsx

@amirroox
Copy link
Contributor Author

Problem

Fix correct display (upside down) of regex in RTL (in CheatSheet, playground, learning Part )

Change

Fix correct display of regex in RTL

File Edit

  • src/components/Step.tsx
  • src/components/CheatSheetCollapse.tsx

@amirroox amirroox changed the title Fixing "Toggle Progress" For RTL Support Fixing "Toggle Progress" For RTL Support and correct display May 27, 2024
@amirroox
Copy link
Contributor Author

Problem

Translation problem in lesson 49 of Persian language

Change

Fixing Persian Translate For lesson 49

File Edit

  • src/localization/fa/learn.json

@amirroox amirroox changed the title Fixing "Toggle Progress" For RTL Support and correct display Fixing "Toggle Progress" For RTL Support & correct display & Fixing Translate May 27, 2024
@amirroox
Copy link
Contributor Author

I apologize if I did not create a separate brunch. 😓💔
@aykutkardas

@aykutkardas aykutkardas merged commit fb69c74 into aykutkardas:develop May 28, 2024
aykutkardas pushed a commit that referenced this pull request May 28, 2024
…ranslate (#363)

* Fixing "Toggle Progress" For RTL Support

* Fix correct display of regex in RTL

* Fixing Persian Translate For lesson 49
@aykutkardas
Copy link
Owner

Thanks for your contribution. ❤️

aykutkardas added a commit that referenced this pull request May 29, 2024
* Fixing "Toggle Progress" For RTL Support & correct display & Fixing Translate (#363)

* Fixing "Toggle Progress" For RTL Support

* Fix correct display of regex in RTL

* Fixing Persian Translate For lesson 49

* Fixing "Toggle Progress" (Better Show) & translation Persian (#365)

* Fixing "Toggle Progress" (Better Show)

* Correcting the translation of a phrase in Persian

---------

Co-authored-by: Amir Mohammad Roozmeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants