Skip to content

[RHI] Add sampler2DArray support #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: wip-v3
Choose a base branch
from
Draft

Conversation

halx99
Copy link
Collaborator

@halx99 halx99 commented Aug 19, 2025

Describe your changes

  • Add sampler2DArray in shader
  • Remove texture array implementation in CPU side
  • Simplify texture binding infos in ProgramState
  • Add new API Texture2D::initWithSpec, all other init stubs will invoke it finally
  • MipLevel improvemnts, remove API generateMipmaps in renderer, auto process in rhi
  • Remove API Texture2D::setRenderTarget
  • Rename Texture2D::getBackendTexture to Texture2D::getRHITexture()

Issue ticket number and link

Checklist before requesting a review

adopt changes

  • FairyGUI etc1 image load
  • metal backend
  • mipmap logic
  • dual sampler shaders
  • ui::MediaPlayer
  • AX_ENABLE_CACHE_TEXTURE_DATA
  • Terrain
  • RenderTexture

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

@halx99 halx99 added this to the 3.0.0 milestone Aug 19, 2025
@halx99 halx99 added enhancement New feature or request Axmol-v3 labels Aug 19, 2025
@halx99 halx99 force-pushed the sampler-2d-array-support branch 3 times, most recently from 4979577 to 3e645ad Compare August 21, 2025 00:27
@halx99 halx99 force-pushed the sampler-2d-array-support branch 4 times, most recently from 24df81d to aee96fe Compare August 21, 2025 09:20
@halx99 halx99 force-pushed the sampler-2d-array-support branch 6 times, most recently from 7eecc74 to 9fcfaa0 Compare August 21, 2025 18:32
@halx99 halx99 force-pushed the sampler-2d-array-support branch from 9fcfaa0 to c98b62f Compare August 21, 2025 19:27
@halx99 halx99 force-pushed the sampler-2d-array-support branch 4 times, most recently from bb01d9c to 05151ae Compare August 22, 2025 18:17
@halx99 halx99 force-pushed the sampler-2d-array-support branch from 05151ae to 3768ee7 Compare August 22, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Axmol-v3 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant