chore: fix more instances of flaky native reference handling #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
added
the
no-changelog
|
This comment has been minimized.
This comment has been minimized.
1 similar comment
Affected ArtifactsChanged in size
|
lauzadis
approved these changes
Aug 13, 2025
| import aws.sdk.kotlin.crt.util.hashing.Sha256 | ||
|
|
||
| /** | ||
| * Utility object for various hash functions | ||
| */ | ||
| public actual object Digest { | ||
| public actual object Digest : WithCrt() { |
There was a problem hiding this comment.
Why does this need WithCrt()? It uses Sha256 but that already has WithCrt applied: https://github.com/awslabs/aws-crt-kotlin/blob/d147cce9d2195e65a56143d0d8e4d45280c0994e/aws-crt-kotlin/native/src/aws/sdk/kotlin/crt/util/hashing/ShaNative.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
(none)
Description of changes:
This change fixes a few more instances of flaky native reference handling:
WithCrtto more classes which require initializing the CRTHttpStreamNativereference in connection callbacks instead of recreating the stream inside every callback, which would make it difficult to properly track closureBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.