Skip to content

Fix warnings found by the Undefined Behavior Sanitizer #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Fix warnings found by the Undefined Behavior Sanitizer #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion source/connection_manager.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,8 @@ static void s_aws_http_connection_manager_execute_transaction(struct aws_connect
* cancels the culling task and then calls this function. If we are not using idle connection culling, we can
* call this function immediately from the start of destruction.
*/
static void s_aws_http_connection_manager_finish_destroy(struct aws_http_connection_manager *manager) {
static void s_aws_http_connection_manager_finish_destroy(void *user_data) {
struct aws_http_connection_manager *manager = user_data;
if (manager == NULL) {
return;
}
Expand Down
7 changes: 4 additions & 3 deletions source/http2_stream_manager.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
/* 3 seconds */
static const size_t s_default_ping_timeout_ms = 3000;

static void s_stream_manager_start_destroy(struct aws_http2_stream_manager *stream_manager);
static void s_aws_http2_stream_manager_build_transaction_synced(struct aws_http2_stream_management_transaction *work);
static void s_aws_http2_stream_manager_execute_transaction(struct aws_http2_stream_management_transaction *work);

Expand Down Expand Up @@ -1016,7 +1015,8 @@ void s_stream_manager_on_cm_shutdown_complete(void *user_data) {
s_stream_manager_destroy_final(stream_manager);
}

static void s_stream_manager_start_destroy(struct aws_http2_stream_manager *stream_manager) {
static void s_stream_manager_start_destroy(void *user_data) {
struct aws_http2_stream_manager *stream_manager = user_data;
STREAM_MANAGER_LOG(TRACE, stream_manager, "Stream Manager reaches the condition to destroy, start to destroy");
/* If there is no outstanding streams, the connections set should be empty. */
AWS_ASSERT(aws_random_access_set_get_size(&stream_manager->synced_data.ideal_available_set) == 0);
Expand All @@ -1031,7 +1031,8 @@ static void s_stream_manager_start_destroy(struct aws_http2_stream_manager *stre
aws_http_connection_manager_release(cm);
}

void s_stream_manager_on_zero_external_ref(struct aws_http2_stream_manager *stream_manager) {
void s_stream_manager_on_zero_external_ref(void *user_data) {
struct aws_http2_stream_manager *stream_manager = user_data;
STREAM_MANAGER_LOG(
TRACE,
stream_manager,
Expand Down
42 changes: 28 additions & 14 deletions source/proxy_strategy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ struct aws_http_proxy_strategy_basic_auth {
struct aws_http_proxy_strategy strategy_base;
};

static void s_destroy_basic_auth_strategy(struct aws_http_proxy_strategy *proxy_strategy) {
static void s_destroy_basic_auth_strategy(void *user_data) {
struct aws_http_proxy_strategy *proxy_strategy = user_data;
struct aws_http_proxy_strategy_basic_auth *basic_auth_strategy = proxy_strategy->impl;

aws_string_destroy(basic_auth_strategy->user_name);
Expand All @@ -102,7 +103,8 @@ struct aws_http_proxy_negotiator_basic_auth {
struct aws_http_proxy_negotiator negotiator_base;
};

static void s_destroy_basic_auth_negotiator(struct aws_http_proxy_negotiator *proxy_negotiator) {
static void s_destroy_basic_auth_negotiator(void *user_data) {
struct aws_http_proxy_negotiator *proxy_negotiator = user_data;
struct aws_http_proxy_negotiator_basic_auth *basic_auth_negotiator = proxy_negotiator->impl;

aws_http_proxy_strategy_release(basic_auth_negotiator->strategy);
Expand Down Expand Up @@ -356,7 +358,8 @@ struct aws_http_proxy_negotiator_one_time_identity {
struct aws_http_proxy_negotiator negotiator_base;
};

static void s_destroy_one_time_identity_negotiator(struct aws_http_proxy_negotiator *proxy_negotiator) {
static void s_destroy_one_time_identity_negotiator(void *user_data) {
struct aws_http_proxy_negotiator *proxy_negotiator = user_data;
struct aws_http_proxy_negotiator_one_time_identity *identity_negotiator = proxy_negotiator->impl;

aws_mem_release(identity_negotiator->allocator, identity_negotiator);
Expand Down Expand Up @@ -432,7 +435,8 @@ static struct aws_http_proxy_strategy_vtable s_one_time_identity_proxy_strategy_
.create_negotiator = s_create_one_time_identity_negotiator,
};

static void s_destroy_one_time_identity_strategy(struct aws_http_proxy_strategy *proxy_strategy) {
static void s_destroy_one_time_identity_strategy(void *user_data) {
struct aws_http_proxy_strategy *proxy_strategy = user_data;
struct aws_http_proxy_strategy_one_time_identity *identity_strategy = proxy_strategy->impl;

aws_mem_release(identity_strategy->allocator, identity_strategy);
Expand Down Expand Up @@ -478,7 +482,8 @@ struct aws_http_proxy_negotiator_forwarding_identity {
struct aws_http_proxy_negotiator negotiator_base;
};

static void s_destroy_forwarding_identity_negotiator(struct aws_http_proxy_negotiator *proxy_negotiator) {
static void s_destroy_forwarding_identity_negotiator(void *user_data) {
struct aws_http_proxy_negotiator *proxy_negotiator = user_data;
struct aws_http_proxy_negotiator_forwarding_identity *identity_negotiator = proxy_negotiator->impl;

aws_mem_release(identity_negotiator->allocator, identity_negotiator);
Expand Down Expand Up @@ -529,7 +534,8 @@ static struct aws_http_proxy_strategy_vtable s_forwarding_identity_strategy_vtab
.create_negotiator = s_create_forwarding_identity_negotiator,
};

static void s_destroy_forwarding_identity_strategy(struct aws_http_proxy_strategy *proxy_strategy) {
static void s_destroy_forwarding_identity_strategy(void *user_data) {
struct aws_http_proxy_strategy *proxy_strategy = user_data;
struct aws_http_proxy_strategy_forwarding_identity *identity_strategy = proxy_strategy->impl;

aws_mem_release(identity_strategy->allocator, identity_strategy);
Expand Down Expand Up @@ -748,7 +754,8 @@ static struct aws_http_proxy_negotiator_tunnelling_vtable s_tunneling_kerberos_p
.connect_request_transform = s_kerberos_tunnel_transform_connect,
};

static void s_destroy_tunneling_kerberos_negotiator(struct aws_http_proxy_negotiator *proxy_negotiator) {
static void s_destroy_tunneling_kerberos_negotiator(void *user_data) {
struct aws_http_proxy_negotiator *proxy_negotiator = user_data;
struct aws_http_proxy_negotiator_tunneling_kerberos *kerberos_negotiator = proxy_negotiator->impl;

aws_http_proxy_strategy_release(kerberos_negotiator->strategy);
Expand Down Expand Up @@ -789,7 +796,8 @@ static struct aws_http_proxy_strategy_vtable s_tunneling_kerberos_strategy_vtabl
.create_negotiator = s_create_tunneling_kerberos_negotiator,
};

static void s_destroy_tunneling_kerberos_strategy(struct aws_http_proxy_strategy *proxy_strategy) {
static void s_destroy_tunneling_kerberos_strategy(void *user_data) {
struct aws_http_proxy_strategy *proxy_strategy = user_data;
struct aws_http_proxy_strategy_tunneling_kerberos *kerberos_strategy = proxy_strategy->impl;

aws_mem_release(kerberos_strategy->allocator, kerberos_strategy);
Expand Down Expand Up @@ -1044,7 +1052,8 @@ static struct aws_http_proxy_negotiator_tunnelling_vtable s_tunneling_ntlm_proxy
.get_retry_directive = s_ntlm_tunnel_get_retry_directive,
};

static void s_destroy_tunneling_ntlm_negotiator(struct aws_http_proxy_negotiator *proxy_negotiator) {
static void s_destroy_tunneling_ntlm_negotiator(void *user_data) {
struct aws_http_proxy_negotiator *proxy_negotiator = user_data;
struct aws_http_proxy_negotiator_tunneling_ntlm *ntlm_negotiator = proxy_negotiator->impl;

aws_string_destroy(ntlm_negotiator->challenge_token);
Expand Down Expand Up @@ -1086,7 +1095,8 @@ static struct aws_http_proxy_strategy_vtable s_tunneling_ntlm_strategy_vtable =
.create_negotiator = s_create_tunneling_ntlm_negotiator,
};

static void s_destroy_tunneling_ntlm_strategy(struct aws_http_proxy_strategy *proxy_strategy) {
static void s_destroy_tunneling_ntlm_strategy(void *user_data) {
struct aws_http_proxy_strategy *proxy_strategy = user_data;
struct aws_http_proxy_strategy_tunneling_ntlm *ntlm_strategy = proxy_strategy->impl;

aws_mem_release(ntlm_strategy->allocator, ntlm_strategy);
Expand Down Expand Up @@ -1189,7 +1199,8 @@ static struct aws_http_proxy_negotiator_tunnelling_vtable
.connect_request_transform = s_ntlm_credential_tunnel_transform_connect,
};

static void s_destroy_tunneling_ntlm_credential_negotiator(struct aws_http_proxy_negotiator *proxy_negotiator) {
static void s_destroy_tunneling_ntlm_credential_negotiator(void *user_data) {
struct aws_http_proxy_negotiator *proxy_negotiator = user_data;
struct aws_http_proxy_negotiator_tunneling_ntlm *ntlm_credential_negotiator = proxy_negotiator->impl;

aws_string_destroy(ntlm_credential_negotiator->challenge_token);
Expand Down Expand Up @@ -1231,7 +1242,8 @@ static struct aws_http_proxy_strategy_vtable s_tunneling_ntlm_credential_strateg
.create_negotiator = s_create_tunneling_ntlm_credential_negotiator,
};

static void s_destroy_tunneling_ntlm_credential_strategy(struct aws_http_proxy_strategy *proxy_strategy) {
static void s_destroy_tunneling_ntlm_credential_strategy(void *user_data) {
struct aws_http_proxy_strategy *proxy_strategy = user_data;
struct aws_http_proxy_strategy_tunneling_ntlm *ntlm_credential_strategy = proxy_strategy->impl;

aws_mem_release(ntlm_credential_strategy->allocator, ntlm_credential_strategy);
Expand Down Expand Up @@ -1548,7 +1560,8 @@ static struct aws_http_proxy_negotiator_tunnelling_vtable s_tunneling_sequence_p
.get_retry_directive = s_sequence_get_retry_directive,
};

static void s_destroy_tunneling_sequence_negotiator(struct aws_http_proxy_negotiator *proxy_negotiator) {
static void s_destroy_tunneling_sequence_negotiator(void *user_data) {
struct aws_http_proxy_negotiator *proxy_negotiator = user_data;
struct aws_http_proxy_negotiator_tunneling_sequence *sequence_negotiator = proxy_negotiator->impl;

size_t negotiator_count = aws_array_list_length(&sequence_negotiator->negotiators);
Expand Down Expand Up @@ -1628,7 +1641,8 @@ static struct aws_http_proxy_strategy_vtable s_tunneling_sequence_strategy_vtabl
.create_negotiator = s_create_tunneling_sequence_negotiator,
};

static void s_destroy_tunneling_sequence_strategy(struct aws_http_proxy_strategy *proxy_strategy) {
static void s_destroy_tunneling_sequence_strategy(void *user_data) {
struct aws_http_proxy_strategy *proxy_strategy = user_data;
struct aws_http_proxy_strategy_tunneling_sequence *sequence_strategy = proxy_strategy->impl;

size_t strategy_count = aws_array_list_length(&sequence_strategy->strategies);
Expand Down