Match CBOR errors via shape name instead of shapeId #587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
There's an ongoing discussion about the right way to match errors on CBOR. This would be one way of checking only against shape name instead of against shapeId. Don't merge this until the discussion is finalized
Diff would look like (
typis the full shape id)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.