Cognito user pool #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the principal id in the JaxRs security context to read the subject property from the user pools authorizer claims. Fixed a bug in the Claims object (private getSubject method). Added some comments to the `ZonedDateTime` methods in the claims object. This should completely address #24.
jt0
reviewed
Apr 21, 2017
| @JsonProperty(value = "auth_time") | ||
| private Long authTime; | ||
| private String exp; | ||
| private String iat; |
There was a problem hiding this comment.
Provide friendly names for "exp" and "iat" like you did for the others?
There was a problem hiding this comment.
I'm providing friendly methods to get the parsed ZonedDateTime called getExpiration and getIssuesAt, that's why I left the raw fields with the same name as the original data
| if (headerValue == null) { | ||
| return values; | ||
| } | ||
| int entryCounter = 1; |
There was a problem hiding this comment.
Not used, forgot there from when I was using the counter to name the key if there was no other name specified. Good catch. Removed.
* Removed unused variable * Removed methods parsing issue and expiration time for token * Changed exp and iat getters and setters to friendly names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge support for Cognito User Pool authorizers (Issue #24)