Disable msk events in tests #3822
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSK tests are created more resources when they start polling (and the Topic we're connecting from doesn't even exist), so let's create the events with `Enabled: false`, so the polling doesn't actually start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSK tests are created more resources when they start polling (and the Topic we're connecting from doesn't even exist), so let's create the events with
Enabled: false, so the polling doesn't actually start.Issue #, if available
Problems seen in our integration testing infrastructure.
Description of changes
Enabled: falseto MSK templates in integration testsEnabledto the schema for MSK. Even though this property is supported, it wasn't part of the schema.s3:putObjectpermissions to the test with an S3 destination for its event (function_with_msk_trigger_and_s3_onfailure_events_destinations.yaml).Description of how you validated changes
pytest --no-cov integration/combination/test_function_with_msk.py -vvChecklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.