Skip to content

fix:decode binary stderr string before dumping it out #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2020
Merged

fix:decode binary stderr string before dumping it out #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bee0c6
fix:decode binary stderr string before dumping it out
Dec 17, 2020
3d5e9ae
fix failing test
Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker_training/process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def check_error(cmd, error_class, capture_error=False, **kwargs):
_, stderr = process.communicate()
# This will force the stderr to be printed after stdout
# If wait is false and cature error is true, we will never see the stderr.
print(stderr)
print(stderr.decode(errors="replace"))
return_code = process.poll()
else:
stderr = None
Expand Down
2 changes: 1 addition & 1 deletion test/unit/test_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def test_run_bash(log, popen, entry_point_type_script):
@patch("subprocess.Popen")
@patch("sagemaker_training.logging_config.log_script_invocation")
def test_run_python(log, popen, entry_point_type_script):
popen().communicate.return_value = (None, 0)
popen().communicate.return_value = (None, b"this is stderr")

with pytest.raises(errors.ExecuteUserScriptError):
process.ProcessRunner("launcher.py", ["--lr", "13"], {}).run(capture_error=True)
Expand Down