Skip to content

Fix: Args for worker nodes in smdataparallel jobs #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Fix: Args for worker nodes in smdataparallel jobs #147

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
082204d
fix: improve worker node wait logic and update EFA flags
Sep 9, 2022
aed5c06
fix worker args for sm dataparallel jobs
Sep 12, 2022
61fcc4d
Merge branch 'master' into fix_worker
satishpasumarthi Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/sagemaker_training/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,12 @@ def _get_by_runner_type(
)
elif identifier is RunnerType.SMDataParallel:
return mpi.WorkerRunner(
user_entry_point, args, env_vars, processes_per_host, env.master_hostname
user_entry_point,
args,
env_vars,
processes_per_host,
env.master_hostname,
env.current_host,
)
elif identifier is RunnerType.MPI and env.is_master:
num_processes = _mpi_param_value(mpi_args, env, params.MPI_NUM_PROCESSES)
Expand Down