SM integration test for TF 1.x #307
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Looks like the test is passing for the PY3 containers. Please add the following test fixtures to prevent it from running for py2 containers: |
| tuner.fit(inputs, job_name=tuning_job_name) | ||
| tuner.wait() | ||
|
|
||
|
|
There was a problem hiding this comment.
Needs this test fixture:
@pytest.mark.skip_py2_containers
There was a problem hiding this comment.
is this required in tf2 branch as well?
There was a problem hiding this comment.
Yes. There are py2 containers for tf2, so this will be required for tf2 as well.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
test/integration/conftest.py
Outdated
| account_id, region, docker_base_name, tag) | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) |
There was a problem hiding this comment.
This was added in a subsequent commit to aid other open PRs, will you be able to remove this fixture?
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
ghost
merged commit 4 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.