fix: add logic to use asimov image for TF 1.14 py2 #997
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
src/sagemaker/fw_utils.py
Outdated
| return ( | ||
| (not is_gov_region) | ||
| and is_merged_versions | ||
| and (is_py3 or _is_tf_14(framework, framework_version)) |
There was a problem hiding this comment.
should this be _is_not_tf_13? because we do expect TF 1.15 py2 as well
There was a problem hiding this comment.
As discussed offline, we will change this method to _is_tf_14_or_later
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| if py_version == "py2" and self._only_python_3_supported(): | ||
| msg = ( | ||
| "Python 2 containers are only available until TensorFlow version 1.13.1. " | ||
| "Python 2 containers are only available until TensorFlow version 1.14.0. " |
There was a problem hiding this comment.
Let's change the warning to say until Jan 1st 2020
4 participants
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.