Skip to content

change: enable simplifiable-if-expression pylint checks #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2019
Merged

change: enable simplifiable-if-expression pylint checks #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbb1766
change: enable simplifiable-if-expression pylint checks
knakad Jul 11, 2019
584f72c
change: simplify expression further
knakad Jul 11, 2019
09379c6
Merge branch 'master' into 20190711-lint-simple-if-exp
knakad Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ disable=
inconsistent-return-statements, # TODO: Make returns consistent
consider-merging-isinstance, # TODO: Merge isinstance where appropriate
consider-using-in, # TODO: Consider merging comparisons with "in"
simplifiable-if-expression, # TODO: Simplify expressions
too-many-public-methods, # TODO: Resolve
ungrouped-imports, # TODO: Group imports
consider-using-ternary, # TODO: Consider ternary expressions
Expand Down
4 changes: 1 addition & 3 deletions src/sagemaker/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,9 +1292,7 @@ def logs_for_job( # noqa: C901 - suppress complexity warning for this method
client = self.boto_session.client("logs", config=config)
log_group = "/aws/sagemaker/TrainingJobs"

job_already_completed = (
True if status == "Completed" or status == "Failed" or status == "Stopped" else False
)
job_already_completed = status == "Completed" or status == "Failed" or status == "Stopped"

state = LogState.TAILING if wait and not job_already_completed else LogState.COMPLETE
dot = False
Expand Down