Skip to content

change: enable signature-differs pylint check #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2019
Merged

change: enable signature-differs pylint check #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cb554b
change: enable signature-differs pylint check
knakad Jul 9, 2019
a5fa725
Merge branch 'master' into 20190709-lint-tighten-signature-differs
knakad Jul 9, 2019
570798f
Merge branch 'master' into 20190709-lint-tighten-signature-differs
knakad Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ disable=
attribute-defined-outside-init, # TODO: Fix scope
protected-access, # TODO: Fix access
abstract-method, # TODO: Fix abstract methods
signature-differs, # TODO: Fix signature overrides
unidiomatic-typecheck, # TODO: Fix typechecks
wrong-import-order, # TODO: Fix import order
no-else-return, # TODO: Remove unnecessary elses
Expand Down
4 changes: 3 additions & 1 deletion src/sagemaker/amazon/lda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ def create_model(self, vpc_config_override=VPC_CONFIG_DEFAULT):
vpc_config=self.get_vpc_config(vpc_config_override),
)

def _prepare_for_training(self, records, mini_batch_size, job_name=None):
def _prepare_for_training( # pylint: disable=signature-differs
self, records, mini_batch_size, job_name=None
):
# mini_batch_size is required, prevent explicit calls with None
if mini_batch_size is None:
raise ValueError("mini_batch_size must be set")
Expand Down
4 changes: 3 additions & 1 deletion src/sagemaker/amazon/ntm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ def create_model(self, vpc_config_override=VPC_CONFIG_DEFAULT):
vpc_config=self.get_vpc_config(vpc_config_override),
)

def _prepare_for_training(self, records, mini_batch_size, job_name=None):
def _prepare_for_training( # pylint: disable=signature-differs
self, records, mini_batch_size, job_name=None
):
if mini_batch_size is not None and (mini_batch_size < 1 or mini_batch_size > 10000):
raise ValueError("mini_batch_size must be in [1, 10000]")
super(NTM, self)._prepare_for_training(
Expand Down