Skip to content

change: skip p2 tests in ap-south-east #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2019
Merged

change: skip p2 tests in ap-south-east #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb6e8d5
change: skip p2 tests in ap-south-east
ChoiByungWook May 30, 2019
cfbb199
modify all training integ tests using p2
ChoiByungWook May 30, 2019
24df973
Merge branch 'master' into skip_tf_test_ap_southeast
ChoiByungWook May 30, 2019
cc53bb2
Merge branch 'master' into skip_tf_test_ap_southeast
ChoiByungWook May 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/integ/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
HOSTING_NO_P2_REGIONS = ['ca-central-1', 'eu-central-1', 'eu-west-2', 'us-west-1']
HOSTING_NO_P3_REGIONS = ['ap-southeast-1', 'ap-southeast-2', 'ap-south-1', 'ca-central-1',
'eu-central-1', 'eu-west-2', 'us-west-1']
TRAINING_NO_P2_REGIONS = ['ap-southeast-1', 'ap-southeast-2']

# EI is currently only supported in the following regions
# regions were derived from https://aws.amazon.com/machine-learning/elastic-inference/pricing/
Expand Down
3 changes: 2 additions & 1 deletion tests/integ/test_chainer_train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ def test_distributed_cpu_training(sagemaker_session, chainer_full_version):
_run_mnist_training_job(sagemaker_session, "ml.c4.xlarge", 2, chainer_full_version)


@pytest.mark.skipif(tests.integ.test_region() in tests.integ.HOSTING_NO_P2_REGIONS,
@pytest.mark.skipif(tests.integ.test_region() in tests.integ.HOSTING_NO_P2_REGIONS
or tests.integ.test_region() in tests.integ.TRAINING_NO_P2_REGIONS,
reason='no ml.p2 instances in these regions')
def test_distributed_gpu_training(sagemaker_session, chainer_full_version):
_run_mnist_training_job(sagemaker_session, "ml.p2.xlarge", 2, chainer_full_version)
Expand Down
3 changes: 2 additions & 1 deletion tests/integ/test_pytorch_train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ def test_deploy_model(pytorch_training_job, sagemaker_session):
assert output.shape == (batch_size, 10)


@pytest.mark.skipif(tests.integ.test_region() in tests.integ.HOSTING_NO_P2_REGIONS,
@pytest.mark.skipif(tests.integ.test_region() in tests.integ.HOSTING_NO_P2_REGIONS
or tests.integ.test_region() in tests.integ.TRAINING_NO_P2_REGIONS,
reason='no ml.p2 instances in these regions')
def test_async_fit_deploy(sagemaker_session, pytorch_full_version):
training_job_name = ""
Expand Down
3 changes: 2 additions & 1 deletion tests/integ/test_tf_cifar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ def __call__(self, data):
@pytest.mark.canary_quick
@pytest.mark.skipif(tests.integ.PYTHON_VERSION != 'py2',
reason="TensorFlow image supports only python 2.")
@pytest.mark.skipif(tests.integ.test_region() in tests.integ.HOSTING_NO_P2_REGIONS,
@pytest.mark.skipif(tests.integ.test_region() in tests.integ.HOSTING_NO_P2_REGIONS
or tests.integ.test_region() in tests.integ.TRAINING_NO_P2_REGIONS,
reason='no ml.p2 instances in these regions')
def test_cifar(sagemaker_session, tf_full_version):
with timeout(minutes=45):
Expand Down
3 changes: 2 additions & 1 deletion tests/integ/test_tf_script_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
'ml.c5.xlarge',
pytest.param('ml.p2.xlarge',
marks=pytest.mark.skipif(
tests.integ.test_region() in tests.integ.HOSTING_NO_P2_REGIONS,
tests.integ.test_region() in tests.integ.HOSTING_NO_P2_REGIONS
or tests.integ.test_region() in tests.integ.TRAINING_NO_P2_REGIONS,
reason='no ml.p2 instances in this region'))])
def instance_type(request):
return request.param
Expand Down