Skip to content

Conversation

@laurenyu
Copy link
Contributor

Description of changes:
Don't think there was a reason this wasn't done before, so it'd be nice to have for consistency with other similar classes.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #610 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #610   +/-   ##
======================================
  Coverage    92.7%   92.7%           
======================================
  Files          71      71           
  Lines        5418    5418           
======================================
  Hits         5023    5023           
  Misses        395     395
Impacted Files Coverage Δ
src/sagemaker/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfadeeb...0676dcf. Read the comment docs.

@laurenyu laurenyu merged commit e0ad061 into aws:master Jan 23, 2019
@laurenyu laurenyu deleted the tuner-import branch January 23, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants