Skip to content

[hf-tei] add image uri to utils #5287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[hf-tei] add image uri to utils #5287

wants to merge 2 commits into from
+98 −2

Conversation

pagezyhf
Copy link
Contributor

@pagezyhf pagezyhf requested a review from a team as a code owner September 25, 2025 15:00
@mollyheamazon
Copy link
Contributor

Please make sure to fix the unit tests

@cmanou
Copy link

cmanou commented Oct 8, 2025

@pagezyhf do you think you'll get a chance to add the tests for this soon? I am eagerly waiting for it to get merged. Otherwise I am happy to do a pr based off your branch with the tests looks like it just needs the 1.8.2 mapping added to here https://github.com/pagezyhf/sagemaker-python-sdk/blob/fe26625ba93866be89dfe4dc67b8350e0b3c6ceb/tests/unit/sagemaker/image_uris/test_huggingface_llm.py#L22-L37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsareddy0329 rsareddy0329 Awaiting requested review from rsareddy0329 rsareddy0329 is a code owner automatically assigned from aws/sagemaker-ml-frameworks

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pagezyhf @mollyheamazon @cmanou @pintaoz-aws