fix: fixed implementation of fail_on_violation for transform with monitoring #4442

keshav-chandak · 2024-02-21T08:37:30Z

Issue #, if available:

Description of changes:
Implemeted the fail_on_violation for the transform_with_monitoring step for sagemaker.transformer

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mufaddal-rohawala · 2024-02-21T09:36:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 688a37d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-21T09:38:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 688a37d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-21T10:00:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 688a37d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-21T10:37:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 688a37d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov · 2024-02-21T10:39:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.15%. Comparing base (8b206ba) to head (88ab7ee).
Report is 38 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4442      +/-   ##
==========================================
+ Coverage   86.94%   87.15%   +0.20%     
==========================================
  Files        1203      387     -816     
  Lines      107211    35777   -71434     
==========================================
- Hits        93211    31180   -62031     
+ Misses      14000     4597    -9403

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mufaddal-rohawala · 2024-02-21T11:14:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 688a37d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-22T07:58:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9f42637
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-22T08:00:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9f42637
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-22T08:30:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9f42637
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-22T08:32:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9f42637
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-22T08:57:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9f42637
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-23T13:53:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 24b7c24
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-23T14:47:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 24b7c24
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-23T14:48:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 24b7c24
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-23T15:20:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 24b7c24
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-23T15:24:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 24b7c24
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/transformer.py

mohanasudhan · 2024-02-23T20:58:11Z

/bot run pr, unit-tests

mufaddal-rohawala · 2024-02-24T07:33:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6a6dbea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-24T07:35:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6a6dbea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-24T08:04:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6a6dbea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-24T08:33:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6a6dbea
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-24T09:15:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6a6dbea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…itoring

mufaddal-rohawala · 2024-02-26T06:54:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 88ab7ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-26T06:56:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 88ab7ee
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-26T07:21:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 88ab7ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-26T07:29:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 88ab7ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-26T08:03:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 88ab7ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-26T09:21:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 88ab7ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-26T09:24:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 88ab7ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-26T09:26:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 88ab7ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-26T10:10:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 88ab7ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-26T10:27:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 88ab7ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…itoring (aws#4442) Co-authored-by: Keshav Chandak <[email protected]>

keshav-chandak requested a review from a team as a code owner February 21, 2024 08:37

keshav-chandak requested review from knikure and removed request for a team February 21, 2024 08:37

adeel-zafar approved these changes Feb 21, 2024

View reviewed changes

keshav-chandak force-pushed the master branch from 9f42637 to 24b7c24 Compare February 23, 2024 13:47

mohanasudhan reviewed Feb 23, 2024

View reviewed changes

src/sagemaker/transformer.py Show resolved Hide resolved

mohanasudhan approved these changes Feb 23, 2024

View reviewed changes

keshav-chandak force-pushed the master branch from 24b7c24 to 6a6dbea Compare February 24, 2024 06:33

keshav-chandak force-pushed the master branch from 6a6dbea to d5ba889 Compare February 26, 2024 05:57

fix: fixed implementation of fail_on_violation for transform with mon…

88ab7ee

…itoring

keshav-chandak force-pushed the master branch from d5ba889 to 88ab7ee Compare February 26, 2024 05:58

mohanasudhan merged commit e4de46c into aws:master Feb 26, 2024

bencrabtree pushed a commit to bencrabtree/sagemaker-python-sdk that referenced this pull request Feb 28, 2024

fix: fixed implementation of fail_on_violation for transform with mon…

7323410

…itoring (aws#4442) Co-authored-by: Keshav Chandak <[email protected]>

malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024

fix: fixed implementation of fail_on_violation for transform with mon…

8181fe2

…itoring (aws#4442) Co-authored-by: Keshav Chandak <[email protected]>

jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024

fix: fixed implementation of fail_on_violation for transform with mon…

c9d0c01

…itoring (aws#4442) Co-authored-by: Keshav Chandak <[email protected]>

fix: fixed implementation of fail_on_violation for transform with monitoring #4442

fix: fixed implementation of fail_on_violation for transform with monitoring #4442

Uh oh!

Conversation

keshav-chandak commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

mufaddal-rohawala commented Feb 21, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 21, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 21, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 21, 2024

AWS CodeBuild CI Report

Uh oh!

codecov bot commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mufaddal-rohawala commented Feb 21, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 22, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 22, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 22, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 22, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 22, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 23, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 23, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 23, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 23, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 23, 2024

AWS CodeBuild CI Report

Uh oh!

Uh oh!

mohanasudhan commented Feb 23, 2024

Uh oh!

mufaddal-rohawala commented Feb 24, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 24, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 24, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 24, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 24, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 26, 2024

AWS CodeBuild CI Report

Uh oh!

keshav-chandak commented Feb 21, 2024 •

edited

Loading

codecov bot commented Feb 21, 2024 •

edited

Loading