change: Update pytorch.json with 2.0.1 for inference and training #4102

sallyseok · 2023-08-30T00:57:24Z

Issue #, if available:

Description of changes:
Updated PyTorch version from 2.0.0 to 2.0.1 for both inference and training.
For background, I had previously opened a PR to update just inference (because training wasn't released yet), but found that the tests don't support version mismatch between training and inference. SM PT 2.0.1 Training was just released so I'm un-pausing this work.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-08-30T00:59:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-30T00:59:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-30T00:59:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-30T01:02:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-30T01:02:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-30T01:03:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-30T01:06:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-30T01:07:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-30T01:07:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-30T02:14:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-30T02:43:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9e8aa58
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-08-30T02:43:46Z

Codecov Report

Patch coverage: 82.60% and project coverage change: +0.11% 🎉

Comparison is base (9517bdd) 90.23% compared to head (9e8aa58) 90.34%.
Report is 14 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4102      +/-   ##
==========================================
+ Coverage   90.23%   90.34%   +0.11%     
==========================================
  Files        1312      312    -1000     
  Lines      115920    28676   -87244     
==========================================
- Hits       104599    25907   -78692     
+ Misses      11321     2769    -8552

Files Changed	Coverage Δ
src/sagemaker/remote_function/client.py	`97.54% <ø> (ø)`
src/sagemaker/workflow/utilities.py	`92.04% <ø> (ø)`
src/sagemaker/stabilityai/stability_utils.py	`72.72% <72.72%> (ø)`
src/sagemaker/remote_function/job.py	`89.75% <83.33%> (ø)`
src/sagemaker/image_uris.py	`97.83% <100.00%> (ø)`
src/sagemaker/stabilityai/__init__.py	`100.00% <100.00%> (ø)`

... and 1618 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sthodimi

/bot run notebook-tests

sthodimi

/bot run unit-tests

sagemaker-bot · 2023-08-30T18:56:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-30T19:35:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9e8aa58
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sthodimi

LGTM

jeet4320 · 2023-08-30T20:33:32Z

please hold off merge, we will update it until end of this week.

update pytorch version to 2.0.1 for both inference and training

9e8aa58

sallyseok requested a review from a team as a code owner August 30, 2023 00:57

sallyseok requested review from sthodimi and removed request for a team August 30, 2023 00:57

sallyseok changed the title ~~Update pytorch.json with 2.0.1 for inference and training~~ change: Update pytorch.json with 2.0.1 for inference and training Aug 30, 2023

sthodimi reviewed Aug 30, 2023

View reviewed changes

knikure assigned sthodimi Aug 30, 2023

sthodimi approved these changes Aug 30, 2023

View reviewed changes

knikure merged commit 8d5d7fd into aws:master Aug 31, 2023

change: Update pytorch.json with 2.0.1 for inference and training #4102

change: Update pytorch.json with 2.0.1 for inference and training #4102

Uh oh!

Conversation

sallyseok commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sthodimi left a comment

Choose a reason for hiding this comment

Uh oh!

sthodimi left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 30, 2023

AWS CodeBuild CI Report

Uh oh!

sthodimi left a comment

Choose a reason for hiding this comment

Uh oh!

jeet4320 commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sallyseok commented Aug 30, 2023 •

edited

Loading

codecov-commenter commented Aug 30, 2023 •

edited

Loading

jeet4320 commented Aug 30, 2023 •

edited

Loading