Skip to content

feature: Add TLV accounts for 1P Algorithms #4054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2023
Merged

feature: Add TLV accounts for 1P Algorithms #4054

merged 1 commit into from
Aug 11, 2023

Conversation

@malav-shastri
Copy link
Member

@malav-shastri malav-shastri commented Aug 7, 2023 •
edited
Loading

Issue #, if available:

Description of changes:
Adding new region TLV account

Testing done:
tox -e py39 -- tests/unit/test_amazon_estimator.py
tox -e black-format
tox -e py39 -- tests/unit/sagemaker/image_uris/test_xgboost.py
tox -e py39 -- tests/unit/sagemaker/image_uris/test_sklearn.py
tox -e py39 -- tests/unit/sagemaker/image_uris/test_algos.py

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malav-shastri malav-shastri requested a review from a team as a code owner August 7, 2023 18:58
@malav-shastri malav-shastri requested review from benieric and haixiw and removed request for a team August 7, 2023 18:58
@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 7, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 2291264
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 7, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 2291264
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 7, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 2291264
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 7, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 2291264
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #4054 (b281592) into master (3cafa53) will decrease coverage by 0.73%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4054      +/-   ##
==========================================
- Coverage   90.20%   89.47%   -0.73%     
==========================================
  Files        1296      306     -990     
  Lines      114824    28392   -86432     
==========================================
- Hits       103572    25405   -78167     
+ Misses      11252     2987    -8265

see 1602 files with indirect coverage changes

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 7, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 2291264
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure self-assigned this Aug 11, 2023
@knikure knikure force-pushed the TLVRegionsExpanssion branch from 2291264 to b281592 Compare August 11, 2023 01:29
@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 11, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b281592
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure
knikure reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@knikure knikure left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 11, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: b281592
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 11, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: b281592
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 11, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: b281592
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 11, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: b281592
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 11, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: b281592
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure merged commit 1b3bed3 into aws:master Aug 11, 2023
@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 11, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: b281592
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benieric benieric Awaiting requested review from benieric benieric is a code owner automatically assigned from aws/sagemaker-ml-frameworks

@haixiw haixiw Awaiting requested review from haixiw

2 more reviewers

@whittech1 whittech1 whittech1 approved these changes

@knikure knikure knikure approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@knikure knikure

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malav-shastri @sagemaker-bot @codecov-commenter @whittech1 @knikure