Skip to content

fix: update apache airflow and update test requirements #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2023
Merged

fix: update apache airflow and update test requirements #3855

merged 1 commit into from
May 16, 2023

Conversation

@mufaddal-rohawala
Copy link
Member

@mufaddal-rohawala mufaddal-rohawala commented May 12, 2023 •
edited
Loading

Issue #, if available:

Description of changes:

  • Updating airflow to 2.6.0
  • Moving relevant local and scipy requirements in test requirements. Skipping docker compose due to conflicts with airflow and also pypi seems to be an unsupported distribution partner for latest docker compose releases. We install docker compose in our infra image directly.
The conflict is caused by:
    sagemaker[test] 2.154.1.dev0 depends on jsonschema
    apache-airflow 2.6.0 depends on jsonschema>=4.0.0
    docker-compose 1.29.2 depends on jsonschema<4 and >=2.5.1

Testing done:

  • Tested package resolution locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mufaddal-rohawala mufaddal-rohawala requested a review from a team as a code owner May 12, 2023 19:15
@mufaddal-rohawala mufaddal-rohawala requested review from claytonparnell and removed request for a team May 12, 2023 19:15
@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9dba4d0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9dba4d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9dba4d0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9dba4d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9dba4d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9dba4d0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023 •
edited
Loading

Codecov Report

Merging #3855 (9dba4d0) into master (fd90b1d) will decrease coverage by 0.72%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3855      +/-   ##
==========================================
- Coverage   89.96%   89.25%   -0.72%     
==========================================
  Files        1140      267     -873     
  Lines      105300    26025   -79275     
==========================================
- Hits        94733    23228   -71505     
+ Misses      10567     2797    -7770
Impacted Files Coverage Δ
...agemaker/serverless/serverless_inference_config.py 100.00% <100.00%> (ø)

... and 1406 files with indirect coverage changes

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9dba4d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure self-requested a review May 15, 2023 19:02
@knikure knikure self-assigned this May 15, 2023
@knikure knikure removed the request for review from claytonparnell May 15, 2023 19:02
@knikure knikure linked an issue May 15, 2023 that may be closed by this pull request
Docker Compose V2 compatibility for local mode #3659
Closed
knikure
knikure reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@knikure knikure left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9dba4d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9dba4d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9dba4d0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9dba4d0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure mentioned this pull request May 16, 2023
Closed
@knikure knikure force-pushed the fix-dependebot-airflow branch from 9dba4d0 to 2585bec Compare May 16, 2023 18:58
@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 2585bec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 2585bec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 2585bec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 2585bec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure merged commit 1fe8619 into aws:master May 16, 2023
@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 16, 2023

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 2585bec
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pdifranc pdifranc mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@knikure knikure knikure left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@knikure knikure

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docker Compose V2 compatibility for local mode

4 participants

@mufaddal-rohawala @sagemaker-bot @codecov-commenter @knikure