-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: Make type annotation of UploadedCode consistent #3839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
knikure
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bot run all
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## master #3839 +/- ##
==========================================
- Coverage 89.96% 89.25% -0.72%
==========================================
Files 1140 267 -873
Lines 105616 26100 -79516
==========================================
- Hits 95021 23296 -71725
+ Misses 10595 2804 -7791
|
knikure
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bot run notebook-tests
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Description of changes:
Corrected the documentation and type annotations for some methods and variables which handle
UploadedCodeinstances. In some places they were referred to asstrand in some places as the nonexistentUserCodetype. Now they are allUploadedCode(orOptional[UploadedCode]).Testing done:
tox tests/unitMerge Checklist
General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.