feature: Partition support for DJLModel using SM Training job #3820

sindhuvahinis · 2023-04-27T05:40:37Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

src/sagemaker/djl_inference/model.py

doc/frameworks/djl/using_djl.rst

claytonparnell

/bot run all

sagemaker-bot · 2023-05-12T17:47:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: df31f0b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run all

sagemaker-bot · 2023-05-12T18:33:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ac77207
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

siddvenk · 2023-05-12T18:52:46Z

src/sagemaker/djl_inference/model.py

+        # creates a training job to do partitions
+        estimator.fit(
+            inputs=container_def["ModelDataUrl"],
+            wait=True,


Should we let the user configure this? I think by default we can make it blocking, but user may want to have this be async

src/sagemaker/djl_inference/model.py

sagemaker-bot · 2023-05-12T19:10:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ac77207
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T19:18:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ac77207
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T19:22:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ac77207
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-12T19:33:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ac77207
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run slow-tests, unit-tests

sagemaker-bot · 2023-05-14T02:19:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ac77207
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-14T02:19:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ac77207
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sindhuvahinis · 2023-05-15T17:41:09Z

/bot run all

claytonparnell

/bot run pr

sagemaker-bot · 2023-05-15T18:44:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 72b2af5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-15T18:53:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 72b2af5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-15T18:53:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 72b2af5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-15T19:05:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 72b2af5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-15T20:50:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 72b2af5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-15T21:17:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 72b2af5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-15T23:12:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 72b2af5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-15T23:49:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 72b2af5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sindhuvahinis · 2023-05-16T16:15:01Z

/bot run slow-tests, unit-tests

knikure

/bot run slow-tests, pr

sagemaker-bot · 2023-05-16T17:21:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 72b2af5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T17:22:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 72b2af5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sindhuvahinis · 2023-05-16T17:52:43Z

/bot run all

knikure

/bot run pr

sagemaker-bot · 2023-05-16T19:12:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ff0c638
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T19:13:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ff0c638
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T19:22:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ff0c638
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T19:23:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ff0c638
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T20:26:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ff0c638
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-16T22:55:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7759f1b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sindhuvahinis force-pushed the djl_partition branch from 111b9cb to a256a81 Compare April 28, 2023 04:29

sindhuvahinis changed the title ~~Partition support for DJLModel using SM Training job~~ feature: Partition support for DJLModel using SM Training job May 1, 2023

sindhuvahinis force-pushed the djl_partition branch 3 times, most recently from c64e307 to 33ceb4e Compare May 1, 2023 16:57

sindhuvahinis marked this pull request as ready for review May 1, 2023 16:57

sindhuvahinis requested a review from a team as a code owner May 1, 2023 16:57

sindhuvahinis requested review from claytonparnell and removed request for a team May 1, 2023 16:57

siddvenk reviewed May 2, 2023

View reviewed changes

src/sagemaker/djl_inference/model.py Outdated Show resolved Hide resolved

doc/frameworks/djl/using_djl.rst Outdated Show resolved Hide resolved

sindhuvahinis force-pushed the djl_partition branch 5 times, most recently from d6722d8 to cea9cc7 Compare May 3, 2023 20:40

lanking520 approved these changes May 4, 2023

View reviewed changes

knikure assigned claytonparnell May 5, 2023

sindhuvahinis force-pushed the djl_partition branch 3 times, most recently from 70c932d to df31f0b Compare May 11, 2023 20:44

claytonparnell reviewed May 12, 2023

View reviewed changes

claytonparnell force-pushed the djl_partition branch from df31f0b to ac77207 Compare May 12, 2023 18:26

claytonparnell reviewed May 12, 2023

View reviewed changes

siddvenk reviewed May 12, 2023

View reviewed changes

claytonparnell reviewed May 14, 2023

View reviewed changes

sindhuvahinis force-pushed the djl_partition branch from ac77207 to 72b2af5 Compare May 15, 2023 17:20

siddvenk approved these changes May 15, 2023

View reviewed changes

claytonparnell reviewed May 15, 2023

View reviewed changes

knikure reviewed May 16, 2023

View reviewed changes

knikure approved these changes May 16, 2023

View reviewed changes

feature: Partition support for DJLModel using SM Training job

7759f1b

knikure force-pushed the djl_partition branch from ff0c638 to 7759f1b Compare May 16, 2023 22:09

knikure merged commit 4bc49e5 into aws:master May 16, 2023

feature: Partition support for DJLModel using SM Training job #3820

feature: Partition support for DJLModel using SM Training job #3820

Uh oh!

Conversation

sindhuvahinis commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

Uh oh!

Uh oh!

claytonparnell left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

claytonparnell left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

siddvenk May 12, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 12, 2023

AWS CodeBuild CI Report

Uh oh!

claytonparnell left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented May 14, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 14, 2023

AWS CodeBuild CI Report

Uh oh!

sindhuvahinis commented May 15, 2023

Uh oh!

claytonparnell left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented May 15, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 15, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 15, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 15, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 15, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 15, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 15, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 15, 2023

AWS CodeBuild CI Report

Uh oh!

sindhuvahinis commented Apr 27, 2023 •

edited

Loading

claytonparnell left a comment •

edited

Loading

knikure left a comment •

edited

Loading