feature: SDK Defaults - S3 Params for Session #3811

rubanh · 2023-04-24T22:03:09Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rubanh · 2023-04-24T23:27:23Z

/bot run all

sagemaker-bot · 2023-04-25T00:33:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e757701
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T00:49:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7bb2d65
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T01:15:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7bb2d65
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T01:27:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7bb2d65
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T01:29:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7bb2d65
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T01:33:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7bb2d65
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rubanh · 2023-04-25T06:04:03Z

/bot run all

sagemaker-bot · 2023-04-25T06:20:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2e5223d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-04-25T06:22:22Z

Codecov Report

Merging #3811 (1eb028b) into master (0f37695) will decrease coverage by 0.62%.
The diff coverage is 92.50%.

❗ Current head 1eb028b differs from pull request most recent head 7ec5bfb. Consider uploading reports for the commit 7ec5bfb to get more accurate results

@@            Coverage Diff             @@
##           master    #3811      +/-   ##
==========================================
- Coverage   89.96%   89.35%   -0.62%     
==========================================
  Files        1140      268     -872     
  Lines      105744    26180   -79564     
==========================================
- Hits        95129    23392   -71737     
+ Misses      10615     2788    -7827

Impacted Files	Coverage Δ
src/sagemaker/model_monitor/data_capture_config.py	`68.75% <ø> (ø)`
src/sagemaker/model_monitor/model_monitoring.py	`69.60% <ø> (ø)`
src/sagemaker/model_monitor/monitoring_files.py	`42.15% <ø> (ø)`
src/sagemaker/remote_function/job.py	`88.93% <ø> (ø)`
src/sagemaker/tensorflow/estimator.py	`93.02% <0.00%> (ø)`
src/sagemaker/workflow/clarify_check_step.py	`96.91% <ø> (ø)`
src/sagemaker/workflow/pipeline.py	`95.03% <0.00%> (ø)`
src/sagemaker/workflow/pipeline_context.py	`96.19% <ø> (ø)`
src/sagemaker/workflow/quality_check_step.py	`99.21% <ø> (ø)`
src/sagemaker/experiments/_helper.py	`37.77% <33.33%> (ø)`
... and 18 more

... and 1380 files with indirect coverage changes

sagemaker-bot · 2023-04-25T06:58:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2e5223d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T06:59:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2e5223d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T07:03:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2e5223d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T07:13:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2e5223d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rubanh · 2023-04-25T07:52:00Z

/bot run notebook-tests, slow-tests

sagemaker-bot · 2023-04-25T08:42:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7ea8742
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T08:49:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7ea8742
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T08:50:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7ea8742
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T09:01:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7ea8742
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-25T10:52:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7ea8742
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T04:52:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c4d3dab
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T05:10:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c4d3dab
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T05:23:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c4d3dab
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T07:28:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0addcb3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T07:32:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0addcb3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T07:50:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0addcb3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T07:54:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0addcb3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T09:43:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0addcb3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T18:33:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1eb028b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rubanh · 2023-05-18T18:37:38Z

/bot run slow-tests

sagemaker-bot · 2023-05-18T19:12:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1eb028b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T19:14:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1eb028b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T19:33:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1eb028b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T19:40:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1eb028b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…fix & ability to set an SDK-wide S3 Key Prefix through Session

… code since initial commit

… Rename sagemaker_config keys

sagemaker-bot · 2023-05-18T22:58:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7ec5bfb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T23:06:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7ec5bfb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T23:18:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7ec5bfb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T23:23:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7ec5bfb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-18T23:26:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7ec5bfb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rubanh requested a review from a team as a code owner April 24, 2023 22:03

rubanh requested review from trajanikant and removed request for a team April 24, 2023 22:03

rubanh marked this pull request as draft April 24, 2023 23:27

rubanh changed the title ~~SDK Defaults - S3 Params for Session (still in development, not ready for human review)~~ SDK Defaults - S3 Params for Session (draft) Apr 25, 2023

rubanh force-pushed the sdk-defaults-session-s3 branch 2 times, most recently from 491c37f to 7bb2d65 Compare April 25, 2023 00:37

mufaddal-rohawala assigned trajanikant Apr 25, 2023

rubanh force-pushed the sdk-defaults-session-s3 branch from 7bb2d65 to 2e5223d Compare April 25, 2023 06:03

rubanh force-pushed the sdk-defaults-session-s3 branch from 2e5223d to 7ea8742 Compare April 25, 2023 07:51

rubanh force-pushed the sdk-defaults-session-s3 branch from c4d3dab to 0addcb3 Compare May 18, 2023 06:42

rubanh force-pushed the sdk-defaults-session-s3 branch from 0addcb3 to 1eb028b Compare May 18, 2023 18:26

Ruban Hussain added 7 commits May 18, 2023 15:11

feature: SDK Defaults Config - Support for Session default_bucket

8c7b09b

feature: SDK Defaults Config - Support for Session default_bucket_pre…

7cc82db

…fix & ability to set an SDK-wide S3 Key Prefix through Session

feature: SDK Defaults Config - SDK-wide S3 Key Prefix - more unit tests

c169697

feature: SDK Defaults Config - SDK-wide S3 Key Prefix - added for new…

b8c8f92

… code since initial commit

feature: SDK Defaults Config - Session Default S3 Bucket and Prefix -…

4a49130

… Rename sagemaker_config keys

fix: unit test fixes

94eb09b

fix: unit test fix for test_pipeline_session_init

7ec5bfb

rubanh force-pushed the sdk-defaults-session-s3 branch from 1eb028b to 7ec5bfb Compare May 18, 2023 22:13

knikure merged commit cb019f6 into aws:master May 18, 2023

feature: SDK Defaults - S3 Params for Session #3811

feature: SDK Defaults - S3 Params for Session #3811

Uh oh!

Conversation

rubanh commented Apr 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

rubanh commented Apr 24, 2023

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

rubanh commented Apr 25, 2023

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

rubanh commented Apr 25, 2023 • edited by knikure Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2023

AWS CodeBuild CI Report

rubanh commented Apr 24, 2023 •

edited

Loading

codecov-commenter commented Apr 25, 2023 •

edited

Loading

rubanh commented Apr 25, 2023 •

edited by knikure

Loading