Skip to content

fix: Do not specify S3 path for disabled profiler #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2022
Merged

fix: Do not specify S3 path for disabled profiler #3546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16605c1
fix: do not specify S3 path for disabled profiler
Dec 16, 2022
46cef2a
fix: do not specify S3 path for disabled profiler
Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/sagemaker/debugger/profiler_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,11 @@ def _to_request_dict(self):
"""
profiler_config_request = {}

if self.s3_output_path is not None:
if (
self.s3_output_path is not None
and self.disable_profiler is not None
and self.disable_profiler is False
):
profiler_config_request["S3OutputPath"] = self.s3_output_path

profiler_config_request["DisableProfiler"] = self.disable_profiler
Expand Down