Skip to content

fix: Fix failing jumpstart cache unit tests #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2022
Merged

fix: Fix failing jumpstart cache unit tests #3514

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d577e3e
chore: fix failing jumpstart cache unit tests
evakravi Dec 8, 2022
b681d81
chore: pin packaging==22.0
evakravi Dec 8, 2022
216cab7
chore: pin packaging==20.9
evakravi Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sagemaker/jumpstart/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import boto3
import botocore
from packaging.version import Version
from packaging.specifiers import SpecifierSet
from packaging.specifiers import SpecifierSet, InvalidSpecifier
from sagemaker.jumpstart.constants import (
ENV_VARIABLE_JUMPSTART_MANIFEST_LOCAL_ROOT_DIR_OVERRIDE,
ENV_VARIABLE_JUMPSTART_SPECS_LOCAL_ROOT_DIR_OVERRIDE,
Expand Down Expand Up @@ -371,7 +371,10 @@ def _select_version(
return None
return str(max(available_versions))

spec = SpecifierSet(f"=={semantic_version_str}")
try:
spec = SpecifierSet(f"=={semantic_version_str}")
except InvalidSpecifier:
raise KeyError(f"Bad semantic version: {semantic_version_str}")
available_versions_filtered = list(spec.filter(available_versions))
return (
str(max(available_versions_filtered)) if available_versions_filtered != [] else None
Expand Down