Skip to content

fix: Update localmode code to decode urllib response as UTF8 #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2022
Merged

fix: Update localmode code to decode urllib response as UTF8 #3284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/local/entities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ def start(self, input_data, output_data, transform_resources, **kwargs):
endpoint_url = "http://%s:%d/execution-parameters" % (get_docker_host(), serving_port)
response, code = _perform_request(endpoint_url)
if code == 200:
execution_parameters = json.loads(response.read())
execution_parameters = json.loads(response.data.decode("utf-8"))
# MaxConcurrentTransforms is ignored because we currently only support 1
for setting in ("BatchStrategy", "MaxPayloadInMB"):
if setting not in kwargs and setting in execution_parameters:
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/test_local_entities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def test_start_local_transform_job(_perform_batch_inference, _perform_request, l

response = Mock()
_perform_request.return_value = (response, 200)
response.read.return_value = '{"BatchStrategy": "SingleRecord"}'
response.data = '{"BatchStrategy": "SingleRecord"}'.encode("UTF-8")
local_transform_job.primary_container["ModelDataUrl"] = "file:///some/model"
local_transform_job.start(input_data, output_data, transform_resources, Environment={})

Expand Down Expand Up @@ -176,9 +176,9 @@ def test_start_local_transform_job_from_remote_docker_host(
output_data = {}
transform_resources = {"InstanceType": "local"}
m_get_docker_host.return_value = "some_host"
perform_request_mock = Mock()
m_perform_request.return_value = (perform_request_mock, 200)
perform_request_mock.read.return_value = '{"BatchStrategy": "SingleRecord"}'
response = Mock()
m_perform_request.return_value = (response, 200)
response.data = '{"BatchStrategy": "SingleRecord"}'.encode("UTF-8")
local_transform_job.primary_container["ModelDataUrl"] = "file:///some/model"
local_transform_job.start(input_data, output_data, transform_resources, Environment={})
endpoints = [
Expand Down