Speed up unit test execution #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By creating a tar file out of the whole Data folder, several unit tests run really slow. Mock the tar file creation as it is not required.
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 45 45
Lines 3163 3163
=======================================
Hits 2894 2894
Misses 269 269Continue to review full report at Codecov.
|
laurenyu
previously approved these changes
Jun 3, 2018
Contributor
laurenyu
left a comment
laurenyu
left a comment
There was a problem hiding this comment.
nice, glad to see this fixed!
yangaws
approved these changes
Jun 7, 2018
Contributor
yangaws
left a comment
yangaws
left a comment
There was a problem hiding this comment.
Just remove the changelog entries before next release. We usually don't do changelog for test and doc updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating a tar file out of the whole Data folder, several unit
tests run really slow. Mock the tar file creation as it is not required.
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.