Add Local Mode Integration tests #192
Merged
+302
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 90.68% 90.68%
=======================================
Files 38 38
Lines 2599 2599
=======================================
Hits 2357 2357
Misses 242 242Continue to review full report at Codecov.
|
iquintero
force-pushed
the
lm_integ_test
branch
2 times, most recently
from
028aab7 to
df93df1
Compare
If we don't have a local session and the image hasn't been pulled then there is a race condition where the NoBotoSession tests need to run after a test that uses boto.
nadiaya
reviewed
May 24, 2018
|
|
||
| DATA_PATH = os.path.join(DATA_DIR, 'iris', 'data') | ||
| LOCK_PATH = os.path.join(DATA_DIR, 'local_mode_lock') | ||
| DEFAULT_REGION = 'us-west-2' |
Contributor
There was a problem hiding this comment.
do we need to run integ tests against different regions?
| endpoint_name = estimator.latest_training_job.name | ||
|
|
||
| try: | ||
| # Since Local Mode uses the same port for serving, we need a lock in order |
Contributor
There was a problem hiding this comment.
should it use a different port? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.